Add support for :nerdfont based :bar_format symbols #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 19, 2025
| incomplete: "♡", | ||
| unknown: "♡♥♡" | ||
| }, | ||
| nerdfont: { # |
There was a problem hiding this comment.
Style/AsciiComments: Use only ascii symbols in comments.
spec/unit/new_spec.rb
Outdated
| ":arrow, :asterisk, :blade, :block, :box, :bracket, " \ | ||
| ":burger, :button, :chevron, :circle, :classic, :crate, :diamond, :dot, " \ | ||
| ":heart, :rectangle, :square, :star, :track, :tread, :triangle, :wave" | ||
| ":heart, :nerdfont, :rectangle, :square, :star, :track, :tread, :triangle, :wave" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [87/80]
brodock
force-pushed
the
brodock/nerdfont-progress-bar
branch
from
f1c4d82 to
6cdd272
Compare
Signed-off-by: Gabriel Mazetto <[email protected]>
brodock
force-pushed
the
brodock/nerdfont-progress-bar
branch
from
6cdd272 to
28f6fae
Compare
brodock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Adds Nerdfont based bar_format symbols
Why are we doing this?
Nerdfont based progress bar is a popular format.
Here is how it looks like:
Benefits
How will the library improve?
Drawbacks
Possible drawbacks applying this change.
Requires a Nerdfont patched font to be able to see it.
The format doesn't allow for specifying right and left corners, so it can't look fully complete as in the example below:
I'm happy to implement additional support for that (requires four new optional style options, something on the lines of :
start_incomplete,start_complete,end_incompleteend_complete. See https://www.nerdfonts.com/cheat-sheet (search fornf-extra-progress)Requirements
masterbranch?